x1439 client - [PR] Treatment type on the SGP management page to help breakdown the worfklows by yoldas · Pull Request #1194 · sanger/stan-client

yoldas · 2026-05-07T19:32:31Z

Changes proposed in this pull request

Add treatment type fragments, mutations, and update queries (core and client branches have slightly different timelines; hence a few cherry picks for client - SDK to be rebuilt again at merge)
Add treatment types multi-select to Allocate a new SGP number in SGP Management page
Add treatment types to the success message
Add treatment types column to work allocation table in SGP Management page
Show treatment types as either blue (enabled) or red (disabled) pills in the table cell
Add treatment types to Records for SGP management spreadsheet download (enabled and disabled)
Add treatment types tab to Configuration page

User feedback: Treatment types should appear after Work Type
(except configuration page tab; they are in alphabetical order)

Not included: "Editable on the final SGP tracking page (later story)"

Miscellaneous:

Update several existing tests. The main update is clearing text before input. Discovered in debugging that tests are not well isolated and input fields accumulate entries across tests. The other main update is async. waitFor to avoid timeout errors. There are also some fixes for false-positives, particularly in releaseOptions tests.
Update cypress container image to 22.14.0 . It is multi-browser version, because chrome-only versions are no longer provided for node 22+ . Chrome version 134 is used for tests.
Fix the issue in Config page for Treatment Types only: after in-client-app navigation, the options set previously look reset.
Add unit tests at component and page level with mocks.
No guards agains null or undefined treatment types; assumed empty array.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
- Check story numbers included
- Check for debug code
- Check version

…9 updateWorkXeniumStudy mutation (3bcf5228) from devel into treatment branch

…ries for x1439

… table header

…to fix the timing issue

…data, reflecting the real UI and backend behaviour

…lect must be the Formik array of strings; not an array of option objects because the component handles mapping internally

…n visiumQC

…page-to-help-breakdown-the-worfklows

…ss UI in work allocation component

…L in tests

… Number form of SGP Management page after feedback

…tion table of SGP Management page after feedback

…on table of SGP Management page after feedback

…sage in SGP management page

…nagement page

…ion of SGP management page

…, and coloured pills in SGP management page

…ta in SGP management page

…ment types config, to prevent showing incorrect config values after navigation within the app

…eniumAnalyser.cy.ts

…y in cypress/e2e/pages/xeniumAnalyser.cy.ts

…umQC mutation in visiumQC spec

…ing within

…es, flat/flatMap, Promise, etc.) in Cypress tests so TypeScript/IDE no longer reports missing lib typings for those APIs

…page-to-help-breakdown-the-worfklows

…ranch

sabrine33 · 2026-05-18T09:30:31Z

-      image: cypress/browsers:node18.12.0-chrome106-ff106
-
-      options: --user 1001
+      image: cypress/browsers:node-22.14.0-chrome-134.0.6998.165-1-ff-136.0.3-edge-134.0.3124.85-1


I would leave this for a separate PR and handle the Node upgrade there, including upgrading the build Node version as well as the github actions versions

At the moment, the tests are running with a different Node version from the one used to build the image

Test use the version from .nvmrc which is 22.14.0 and that matches this image version.
I will still extract the change to another PR as you asked.

sabrine33 · 2026-05-18T09:33:56Z

+              .then((res) => {
+                // revalidate route loader so the configuration page sees server-side updates
+                try {
+                  revalidator.revalidate();


do you mean the server response by 'the server-side updates'?

sabrine33 · 2026-05-18T09:46:34Z

+mockCreateObjectURL();
+
+// Mock URL.createObjectURL for jsdom environment
+mockCreateObjectURL();


this is called twice

sabrine33 · 2026-05-18T10:06:18Z

+    // treatment type pills rendered in the treatment cell
+    // find pill spans anywhere in the row
+    const allSpans = row!.querySelectorAll('span');
+    const pillSpans = Array.from(allSpans).filter((p) => {


If you're using a component specifically for test assertions, the convention is to add a data-testid attribute so it can be reliably selected and tested. This makes it easier to target elements in tests without relying on CSS classes or DOM structure.

yoldas added 3 commits May 7, 2026 19:39

chore(codegen): regenerate sdk.ts after cherry-picking stan-core x150…

4075433

…9 updateWorkXeniumStudy mutation (3bcf5228) from devel into treatment branch

feat(graphql): add treatment type fragments, mutations and update que…

e710d36

…ries for x1439

chore(codegen): regenerate sdk.ts for treatment type operations (x1439)

b10b7c0

yoldas linked an issue May 7, 2026 that may be closed by this pull request

x1439 client—As TS (Katy) I want Treatment type on the SGP management page to help breakdown the worfklows #1182

Open

khelwood removed a link to an issue May 8, 2026

x1439 client—As TS (Katy) I want Treatment type on the SGP management page to help breakdown the worfklows #1182

Open

yoldas added 15 commits May 11, 2026 14:27

feat: add treatment types to work row as pills

a28f5be

feat: add treatment types table header

5828d16

feat: add treatment type and other fields to work factory

1d879a6

feat: add treatment types to work factory for mocks

7bc6e88

feat: add treatment type repository for mocks

1679569

feat: add treatment type to config handlers for mocks

179547a

feat: add treatment types to work handlers for mocks

8cd2c0e

fix: add slash to proxy address to fix request forwarding

e92a886

feat: add treatment types section to config page

d1fe9ba

feat: add multi-select treatment types to SGP management page

9791588

feat: display treatment types as pills and match the cell location to…

09df5b5

… table header

feat: add treatment types support to state machine and work creation

7a522ce

test: wait for the selection action before asserting the URL update, …

06c9049

…to fix the timing issue

test: fix tests to use real group names and labels to match the mock …

cda7220

…data, reflecting the real UI and backend behaviour

fix: for treatment type multi select the value prop for CustomReactSe…

2ad595d

…lect must be the Formik array of strings; not an array of option objects because the component handles mapping internally

yoldas force-pushed the x1439-treatment-type-on-the-sgp-management-page-to-help-breakdown-the-worfklows branch from a81e95b to 2ad595d Compare May 12, 2026 23:26

yoldas added 9 commits May 13, 2026 02:33

fix: join treatment types for the Records for SGP management download

232ffaa

test: clear existing characters in cycles before entering new value i…

9cc5676

…n visiumQC

Merge branch 'devel' into x1439-treatment-type-on-the-sgp-management-…

e17d423

…page-to-help-breakdown-the-worfklows

test: add tests for treatment type selection, chip display, and succe…

38210de

…ss UI in work allocation component

test: add reusable mockCreateObjectURL utility for URL.createObjectUR…

171f502

…L in tests

test: use mockCreateObjectURL helper for work allocation tests

77f177b

feat: move Treatment Types to next to Work Type in Allocate a new SGP…

93a0a6a

… Number form of SGP Management page after feedback

feat: move Treatment Types column to next to Work Type in work alloca…

aa4f1ac

…tion table of SGP Management page after feedback

feat: move Treatment Types cell to next to Work Type in work allocati…

eaec0a5

…on table of SGP Management page after feedback

yoldas added 23 commits May 14, 2026 04:23

feat: list treatment types after work type in create work success mes…

2998ea0

…sage in SGP management page

test: add tests for state machine generated success message in SGP ma…

57e9226

…nagement page

test: add tests for treatment types in Allocate a new SGP number sect…

ee842eb

…ion of SGP management page

test: rename work allocation spec

1d30fe4

test: add treatement type factory

b3ccfdd

test: add tests for work-allocation-table treatment type header, cell…

26b1849

…, and coloured pills in SGP management page

test: add tests for Records for SGP management spreadshet download da…

ca58233

…ta in SGP management page

test: add brief summary to the beginning of the tests as comments

7196c89

test: rename work allocation table test file

9022fa9

test: add tests for treatment types in configuration page

f08940a

fix: revalidate the router loader to use server side values for treat…

053d7cb

…ment types config, to prevent showing incorrect config values after navigation within the app

fix: clear labwareScanInput before each typing in cypress/e2e/pages/x…

20012f2

…eniumAnalyser.cy.ts

fix: prevent looped clicks without waits by checking button visibilit…

9cf9bf7

…y in cypress/e2e/pages/xeniumAnalyser.cy.ts

fix(ci): React Hook React.useMemo has a missing dependency: revalidator

ef8fc84

fix(ci): clear labwareScanInput before typing and wait for RecordVisi…

c399062

…umQC mutation in visiumQC spec

fix(ci): replace array-like iterations with scoped cypress queries us…

898ddf0

…ing within

fix(ci): remove unused import getAllSelect from visiumQC spec

46d82c2

fix(ci): allow ES2015 library APIs (Array.from, Object.values, includ…

123cfca

…es, flat/flatMap, Promise, etc.) in Cypress tests so TypeScript/IDE no longer reports missing lib typings for those APIs

Merge branch 'devel' into x1439-treatment-type-on-the-sgp-management-…

9ec1b47

…page-to-help-breakdown-the-worfklows

fix(ci): match the labware barcode in Amplification test with devel b…

9d9080c

…ranch

fix(ci): match cypress docker image to nvmrc

d8fcfb5

fix(ci): change cypress image version to current exact match with .nvmrc

ebca6b4

fix(ci): slightly higher version of the cypress image

49d677f

yoldas marked this pull request as ready for review May 14, 2026 17:26

yoldas requested review from khelwood and sabrine33 May 14, 2026 17:33

sabrine33 requested changes May 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x1439 client - [PR] Treatment type on the SGP management page to help breakdown the worfklows#1194

x1439 client - [PR] Treatment type on the SGP management page to help breakdown the worfklows#1194
yoldas wants to merge 50 commits into
develfrom
x1439-treatment-type-on-the-sgp-management-page-to-help-breakdown-the-worfklows

yoldas commented May 7, 2026 •

edited

Loading

Uh oh!

sabrine33 May 18, 2026

Uh oh!

yoldas May 18, 2026

Uh oh!

sabrine33 May 18, 2026

Uh oh!

sabrine33 May 18, 2026

Uh oh!

sabrine33 May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yoldas commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request

Instructions for Reviewers

Uh oh!

sabrine33 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

yoldas May 18, 2026

Choose a reason for hiding this comment

Uh oh!

sabrine33 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

sabrine33 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

sabrine33 May 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yoldas commented May 7, 2026 •

edited

Loading